Conversation
Contributor
|
Looks awesome! 🎉 One idea / suggestion to consider later on, I think radius would probably benefit from being a slider? Feels easier to just drag a slider left or right and watch as the radius on the map grows or shrinks, rather than the tedious trial-and-error of constantly tweaking values in a text field. Especially for mobile devices where the keyboard will take up half your screen. |
Member
Author
|
It should just be draggable like it is in the main view, that's something I have to add still. The problem with the slider is the scale, you cant do precious adjustments with a big scale and can't make the radius big if it isn't |
balloob
reviewed
Jan 22, 2020
balloob
reviewed
Jan 22, 2020
balloob
reviewed
Jan 22, 2020
balloob
reviewed
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs home-assistant/core#30774
^ I did change that passive toggle text before commiting ;-)